linux-kernel - Re: [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 24 May 2015 20:47:46 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Shailendra Verma <shailendra.capricorn@...il.com>
Cc:	Roland McGrath <roland@...k.frob.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel:ptrace - Fix typo in comment in function
	__ptrace_unlink().

So this "fix" is wrong.

But you know, even if it was correct... IMO, the fixes like this can
only make sense as a "while at it" part of the meaningful change.

On 05/23, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
> ---
>  kernel/ptrace.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/ptrace.c b/kernel/ptrace.c
> index c8e0e05..46249f9 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -108,7 +108,7 @@ void __ptrace_unlink(struct task_struct *child)
>  
>  	/*
>  	 * If transition to TASK_STOPPED is pending or in TASK_TRACED, kick
> -	 * @child in the butt.  Note that @resume should be used iff @child
> +	 * @child in the butt.  Note that @resume should be used if @child
>  	 * is in TASK_TRACED; otherwise, we might unduly disrupt
>  	 * TASK_KILLABLE sleeps.
>  	 */
> -- 
> 1.7.9.5
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/