linux-kernel - Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 May 2015 21:24:52 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Shailendra Verma <shailendra.capricorn@...il.com>
Cc:	David Airlie <airlied@...ux.ie>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type

On Mon, May 25, 2015 at 9:18 PM, Shailendra Verma
<shailendra.capricorn@...il.com> wrote:
> The variable agp_try_unsupported is bool type.Hence initializing
> with true instead of 1. Also fixing the below checkpatch warning.

Please one logical change per patch.

> WARNING: __initdata should be placed after agp_try_unsupported
> FILE: drivers/char/agp/amd64-agp.c:36:
> static bool __initdata agp_try_unsupported = true;
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
> ---
>  drivers/char/agp/amd64-agp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
> index 0ef3500..14900ea 100644
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -33,7 +33,7 @@
>  #define ULI_X86_64_ENU_SCR_REG         0x54
>
>  static struct resource *aperture_resource;
> -static bool __initdata agp_try_unsupported = 1;
> +static bool agp_try_unsupported __initdata = true;

What issue does this fix? IOW why is assigning 1 wrong?

>  static int agp_bridges_found;

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/