linux-kernel - Re: block_all_signals() usage in DRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 07:31:55 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Richard Weinberger <richard@....at>
Cc:	Dave Airlie <airlied@...ux.ie>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"oleg@...hat.com" <oleg@...hat.com>
Subject: Re: block_all_signals() usage in DRM

On 26 May 2015 at 00:59, Richard Weinberger <richard@....at> wrote:
> Hi!
>
> drivers/gpu/drm/drm_lock.c is the only remaining user of block_all_signals():

It's the only user of it, ever. The API was introduced for the drm locking code.

No other user will ever exist. Just to clear up the an API exists with
one user, we should remove it.


>         /* don't set the block all signals on the master process for now
>          * really probably not the correct answer but lets us debug xkb
>          * xserver for now */
>         if (!file_priv->is_master) {
>                 sigemptyset(&dev->sigmask);
>                 sigaddset(&dev->sigmask, SIGSTOP);
>                 sigaddset(&dev->sigmask, SIGTSTP);
>                 sigaddset(&dev->sigmask, SIGTTIN);
>                 sigaddset(&dev->sigmask, SIGTTOU);
>                 dev->sigdata.context = lock->context;
>                 dev->sigdata.lock = master->lock.hw_lock;
>                 block_all_signals(drm_notifier, dev, &dev->sigmask);
>         }
>
> Is this functionality still in use/needed?
> Otherwise we could get rid of block_all_signals() and unpuzzle the signaling
> code a bit. :-)
>

the functionality is still used, but only on legacy systems, if ABI is
something we care about.

I'll follow up to Oleg mail, just wanted to clarify why there isn't other users.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/