linux-kernel - Re: [Linux-nvdimm] [GIT PULL] PMEM driver for v4.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 11:26:21 +0300
From:	Boaz Harrosh <boaz@...xistor.com>
To:	Christoph Hellwig <hch@....de>
CC:	Matthew Wilcox <willy@...ux.intel.com>,
	Ingo Molnar <mingo@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-nvdimm@...ts.01.org
Subject: Re: [Linux-nvdimm] [GIT PULL] PMEM driver for v4.1

On 05/27/2015 11:11 AM, Christoph Hellwig wrote:
> On Wed, May 27, 2015 at 11:10:21AM +0300, Boaz Harrosh wrote:
>> Hu funny I just looked and I see with ./check auto I get
>> generic/018 1s ... [not run] defragmentation not supported for fstype "m1fs"
>> generic/020 0s ... 0s
>>
>> 019 is not even printing a skip. But if I run it directly I get:
>> generic/019      [not run] /sys/kernel/debug/fail_make_request  not found. \
>> 	Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled
>>
>> So my bad, I will try to properly configure and recreate this failure here
>> as well.
> 
> It fails I/O above the driver.  Any failure in generic/019 is very unlіkely
> to be driver related.
> 

Hm, so then that would be expected right?
__blkdev_put fails to WARN_ON_ONCE(write_inode_now(inode, true))
because the test tells the Kernel to fail IO requests.

__blkdev_put then complains because it has no way to report
the error back to caller.

I would then say that 019 test should expect that this might
happen. Or it should somehow make sure to remove the requests
block before the umount.

Thanks
Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/