linux-kernel - Re: [PATCH 14/16] staging: wilc1000: remove semaphore wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 May 2015 12:16:54 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Rachel Kim <rachel.kim@...el.com>,
	Dean Lee <dean.lee@...el.com>,
	Chris Park <chris.park@...el.com>, devel@...verdev.osuosl.org,
	nicolas.ferre@...el.com, Johnny Kim <johnny.kim@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/16] staging: wilc1000: remove semaphore wrapper

On Fri, May 29, 2015 at 10:52:25PM +0200, Arnd Bergmann wrote:
> The various semaphore functions all directly translate into
> sema_init(), down() and up(), so we can just remove the API.
> 
> This is a mostly automated conversion using simple sed scripts,
> plus some manual changes to account for down() returning no
> error.
> 
> As a positive side-effect, down() no longer hangs after
> receiving a signal, as the original code did by looping around
> down_interruptible.
> 
> The semaphores still need to be turned into mutexes as a
> follow-up step.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c       |  29 +---
>  drivers/staging/wilc1000/fifo_buffer.c            | 108 +++++++-------
>  drivers/staging/wilc1000/fifo_buffer.h            |   2 +-
>  drivers/staging/wilc1000/host_interface.c         | 171 +++++++++-------------
>  drivers/staging/wilc1000/host_interface.h         |  16 +-
>  drivers/staging/wilc1000/wilc_msgqueue.c          |  32 ++--
>  drivers/staging/wilc1000/wilc_oswrapper.h         |   3 -
>  drivers/staging/wilc1000/wilc_platform.h          |   4 +-
>  drivers/staging/wilc1000/wilc_semaphore.c         |  56 -------
>  drivers/staging/wilc1000/wilc_semaphore.h         |  99 -------------
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |  35 ++---
>  drivers/staging/wilc1000/wilc_wfi_netdevice.h     |   4 +-
>  12 files changed, 160 insertions(+), 399 deletions(-)
>  delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.c
>  delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.h
wilc_semaphore still remains in the Makefile.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/