linux-kernel - Re: [PATCH 1/1] drivers: staging: rtl8192e: rtllib_softmac.c: auth parse error code byte order fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 31 May 2015 09:27:55 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Tolga Ceylan <tolga.ceylan@...il.com>
Cc:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>,
	Behan Webster <behanw@...verseincode.com>,
	Matthew Casey <mdcasey@...bloom.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: rtl8192e: rtllib_softmac.c: auth
 parse error code byte order fix

On Tue, May 12, 2015 at 08:43:10PM -0700, Tolga Ceylan wrote:
> Error code returned from auth_parse() should in cpu byte order. Issue
> caught by sparse warning: cast from restricted __le16.
> 
> Signed-off-by: Tolga Ceylan <tolga.ceylan@...il.com>
> ---
>  drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 8f5e88b..98afd3b 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1814,7 +1814,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen)
>  				return -ENOMEM;
>  		}
>  	}
> -	return cpu_to_le16(a->status);
> +	return le16_to_cpu(a->status);

Doesn't apply to my tree :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/