linux-kernel - Re: [PATCH] staging: wlan-ng: fix long line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 31 May 2015 10:01:42 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Douglas Barbonaglia Sathler Figueiredo 
	<eng.douglasfigueiredo@...il.com>
Cc:	vitaly.osipov@...il.com, matt@...ezulu.com,
	tapaswenipathak@...il.com, artemiyv@....org, raghav3276@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: fix long line

On Tue, May 19, 2015 at 01:13:42PM -0300, Douglas Barbonaglia Sathler Figueiredo wrote:
> Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
> 
> Signed-off-by: Douglas Barbonaglia Sathler Figueiredo <eng.douglasfigueiredo@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index 9408644..f4525f8 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -708,7 +708,10 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
>  			continue;
>  		}
>  
> -		/* Validate plug address against chunk data and identify chunk */
> +		/*
> +		 * Validate plug address against
> +		 * chunk data and identify chunk
> +		 */
>  		for (c = 0; c < nfchunks; c++) {
>  			cstart = fchunk[c].addr;
>  			cend = fchunk[c].addr + fchunk[c].len;
> @@ -923,7 +926,8 @@ static int read_fwfile(const struct ihex_binrec *record)
>  				      rcnt,
>  				      s3info[ns3info].len,
>  				      s3info[ns3info].type);
> -			if (((s3info[ns3info].len - 1) * sizeof(u16)) > sizeof(s3info[ns3info].info)) {
> +			if (((s3info[ns3info].len - 1) * sizeof(u16)) >
> +				sizeof(s3info[ns3info].info)) {

Align this under the ( so it doesn't look like it's the logic in the
next block.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/