linux-kernel - Re: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 31 May 2015 12:23:53 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	Shailendra Verma <shailendra.capricorn@...il.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to
 true/false for bool type variable in function
 buffer_icap_set_configuration().

On Wed, May 27, 2015 at 02:33:59PM +0200, Michal Simek wrote:
> +Greg
> 
> On 05/25/2015 09:41 PM, Shailendra Verma wrote:
> > The variable dirty is bool type. Hence assign the variable with
> > bool value true/false instead of 1/0.
> > 
> > Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
> > ---
> >  drivers/char/xilinx_hwicap/buffer_icap.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> > index 05d8977..53c3882 100644
> > --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> > +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> > @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> >  	int status;
> >  	s32 buffer_count = 0;
> >  	s32 num_writes = 0;
> > -	bool dirty = 0;
> > +	bool dirty = false;
> >  	u32 i;
> >  	void __iomem *base_address = drvdata->base_address;
> >  
> > @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> >  
> >  		/* Copy data to bram */
> >  		buffer_icap_set_bram(base_address, buffer_count, data[i]);
> > -		dirty = 1;
> > +		dirty = true;
> >  
> >  		if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
> >  			buffer_count++;
> > @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> >  
> >  		buffer_count = 0;
> >  		num_writes++;
> > -		dirty = 0;
> > +		dirty = false;
> >  	}
> >  
> >  	/* Write unwritten data to ICAP */
> > 
> 
> Tested-by: Michal Simek <michal.simek@...inx.com>

Hm, I don't have the original, can you resend it with your tested-by?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/