linux-kernel - Re: [committed, PATCH] Add -mshared option to x86 ELF assembler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Jun 2015 08:48:48 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	"H.J. Lu" <hjl.tools@...il.com>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Binutils <binutils@...rceware.org>,
	Andy Lutomirski <luto@...nel.org>
Subject: Re: [committed, PATCH] Add -mshared option to x86 ELF assembler

On Mon, Jun 1, 2015 at 4:05 AM, H.J. Lu <hjl.tools@...il.com> wrote:
> On Mon, Jun 1, 2015 at 1:32 AM, Markus Trippelsdorf
> <markus@...ppelsdorf.de> wrote:
>> On 2015.05.15 at 03:34 -0700, H.J. Lu wrote:
>>> This patch adds -mshared option to x86 ELF assembler.  By default,
>>> assembler will optimize out non-PLT relocations against defined non-weak
>>> global branch targets with default visibility.  The -mshared option tells
>>> the assembler to generate code which may go into a shared library
>>> where all non-weak global branch targets with default visibility can
>>> be preempted.  The resulting code is slightly bigger.  This option
>>> only affects the handling of branch instructions.
>>>
>>> This Linux kernel patch is needed to create a working x86 Linux kernel if
>>> it hasn't been applied:
>>>
>>> diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
>>> index ae6588b..b91a00c 100644
>>> --- a/arch/x86/kernel/head_64.S
>>> +++ b/arch/x86/kernel/head_64.S
>>> @@ -339,8 +339,8 @@ early_idt_handlers:
>>>       i = i + 1
>>>       .endr
>>>
>>> -/* This is global to keep gas from relaxing the jumps */
>>> -ENTRY(early_idt_handler)
>>> +/* This is weak to keep gas from relaxing the jumps */
>>> +WEAK(early_idt_handler)
>>>       cld
>>
>> Have you posted the patch to LKML already?
>> (I hit this issue today and it took me a while to figure out the cause.)
>
> A kernel patch will be checked in soon.
>

It already is:

https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/asm&id=cdeb6048940fa4bfb429e2f1cba0d28a11e20cd5

It's currently queued for 4.2.

Ingo, would it make sense to promote this to 4.1?  It's definitely a
violation of the "no development after the merge window" rule, but
it's sort of a build fix.  Alternatively, we could ask Greg et al to
backport it.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/