linux-kernel - Re: [PATCH] fixup! dmaengine: pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Jun 2015 23:31:48 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Joe Perches <joe@...ches.com>
Cc:	Vinod Koul <vinod.koul@...el.com>, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information

Joe Perches <joe@...ches.com> writes:

> Hello Robert.
>
> The return value of that dbg_show_requester_chan function
> was incorrect and the increment of pos was an example of
> why the seq_printf return value was changed to void.
>
> It was a pretty common error and easy to understand given
> the expectation that seq_printf should work like printf.
Sure.

> It's a pity it bit you. but this type of patch collision
> should be a bit more difficult to reoccur in the future.

I got what I deserved. I knew it was coming, I've seen it in other drivers of
mine, but my left brain didn't tell the other half to crosscheck in this
patch. Anyway, it's not a big fixup, so everything is fine now.

Cheers.


-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/