linux-kernel - Re: [PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Jun 2015 11:07:26 +0300
From:	Ben Dooks <ben.dooks@...ethink.co.uk>
To:	Alexey Sokolov <sokolov@...kes.com>, oliver@...kum.org,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers

On 02/06/15 11:05, Alexey Sokolov wrote:
> ATOL FPrint fiscal printers require usb_clear_halt to be executed
> to work properly. Add quirk to fix the issue.
> 
> Signed-off-by: Alexey Sokolov <sokolov@...kes.com>
> ---
>  drivers/usb/class/cdc-acm.c | 9 +++++++++
>  drivers/usb/class/cdc-acm.h | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 5c8f581..9d8a321 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1477,6 +1477,11 @@ skip_countries:
>  		goto alloc_fail8;
>  	}
>  
> +	if (quirks == CLEAR_HALT_CONDITIONS) {
> +		usb_clear_halt(usb_dev, usb_rcvbulkpipe(usb_dev, epread->bEndpointAddress));
> +		usb_clear_halt(usb_dev, usb_sndbulkpipe(usb_dev, epwrite->bEndpointAddress));
> +	}
> +

Given quirks looks like a bitfield, it would be better if this is

	if (quirks & CLEAR_HALT_CONDITIONS) {


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/