linux-kernel - Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Jun 2015 10:11:52 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Stas Sergeev <stsp@...t.ru>
Cc:	linux-leds@...r.kernel.org,
	Linux kernel <linux-kernel@...r.kernel.org>,
	Stas Sergeev <stsp@...rs.sourceforge.net>,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

On 06/01/2015 04:37 PM, Stas Sergeev wrote:
> 01.06.2015 17:19, Jacek Anaszewski пишет:
>>> In fact, the things are more complicated: some drivers do small
>>> udelay()'s but do not use a work-queue. I was not marking them as
>>> FAST, although perhaps they could still be marked as SYNC?
>> This could be handled by adding a property to struct led_classdev
>> for defining minimum acceptable delay. Then FAST flag should not
>> be needed.
> Oh c'mon, that's too difficult!
> Lets just have a flag whether we can do an SW PWM from hrtimer irq callback.
> If we can't do from irq callback - simply do not do anything below 10mS.
> IMHO a simple and practical solution.
> Otherwise we'll not have anything implemented at all I guess.
>

I agree if we are not going to mark the drivers using delays as FAST.
Otherwise the minimum acceptable value stemming from delay value
would be required. I prefer the former.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/