lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 03 Jun 2015 09:53:50 +0800 From: Jiang Liu <jiang.liu@...ux.intel.com> To: Thomas Gleixner <tglx@...utronix.de> CC: Bjorn Helgaas <bhelgaas@...gle.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, Randy Dunlap <rdunlap@...radead.org>, Yinghai Lu <yinghai@...nel.org>, Borislav Petkov <bp@...en8.de>, x86@...nel.org, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, David Vrabel <david.vrabel@...rix.com>, Feng Wu <feng.wu@...el.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Brian Gerst <brgerst@...il.com>, Rusty Russell <rusty@...tcorp.com.au>, Juergen Gross <jgross@...e.com>, Tony Luck <tony.luck@...el.com>, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, linux-acpi@...r.kernel.org, Ingo Molnar <mingo@...nel.org>, xen-devel@...ts.xenproject.org Subject: Re: [Patch v3 27/36] x86, irq: Use access helper irq_data_get_affinity_mask() On 2015/6/3 3:19, Thomas Gleixner wrote: > On Mon, 1 Jun 2015, Jiang Liu wrote: > >> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c >> index 9b62f690b0ff..dfa3a5f5b3d3 100644 >> --- a/arch/x86/kernel/apic/vector.c >> +++ b/arch/x86/kernel/apic/vector.c >> @@ -494,9 +494,8 @@ static int apic_set_affinity(struct irq_data *irq_data, >> >> err = assign_irq_vector(irq, data, dest); >> if (err) { >> - struct irq_data *top = irq_get_irq_data(irq); >> - >> - if (assign_irq_vector(irq, data, top->affinity)) >> + if (assign_irq_vector(irq, data, >> + irq_data_get_affinity_mask(irq_data))) > > Does this patch work w/o moving the affinity mask to common data? I > doubt so, as you remove the retrieval of 'top'. Hi Thomas, This piece of code should be moved into [31/36], otherwise it will break bisecting. I will redo patch this and [31/36] to support bisecting. Thanks! Gerry > > Thanks, > > tglx > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists