linux-kernel - Re: [PATCH] virtio_pci: Clear stale cpumask when setting irq affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Jun 2015 14:55:28 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio_pci: Clear stale cpumask when setting irq affinity

On Thu, Jun 04, 2015 at 04:41:44PM +0800, Jiang Liu wrote:
> The cpumask vp_dev->msix_affinity_masks[info->msix_vector] may contain
> staled information when vp_set_vq_affinity() gets called, so clear it
> before setting the new cpu bit mask.
> 
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>

I have queued this up.
Thanks!

> ---
>  drivers/virtio/virtio_pci_common.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
> index e894eb278d83..eba1b7ac7294 100644
> --- a/drivers/virtio/virtio_pci_common.c
> +++ b/drivers/virtio/virtio_pci_common.c
> @@ -423,6 +423,7 @@ int vp_set_vq_affinity(struct virtqueue *vq, int cpu)
>  		if (cpu == -1)
>  			irq_set_affinity_hint(irq, NULL);
>  		else {
> +			cpumask_clear(mask);
>  			cpumask_set_cpu(cpu, mask);
>  			irq_set_affinity_hint(irq, mask);
>  		}
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/