linux-kernel - Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Jun 2015 16:53:13 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>, joe@...ches.com,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/11] staging: rtl8192e: Remove dead code:
 dig_t::dbg_mode

On Thu, Jun 04, 2015 at 10:48:08AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote:
> > On 03.06.2015 09:26, Sudip Mukherjee wrote:
> > > On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
> > 
> > No, I missed that - this one should also be removed - probably because of similar naming (DbgMode, dbg_mode).
> > Thanks for finding it - I'll fix that in v2.
> > 
> > Apart from that - did you had time/courage to analyze rest of the patches (so I can send v2)?
> 
> at a first glance looked ok to me. I hope you have checked it on the
> hardware as well. but maybe Dan can find something.
> better send v2.

No.  Good job finding that bug.  I had missed it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/