linux-kernel - Re: [next:master 9165/9394] arch/tile/mm/fault.c:845:1: warning: label 'done' defined but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 4 Jun 2015 13:52:50 -0400
From:	Chris Metcalf <cmetcalf@...hip.com>
To:	kbuild test robot <fengguang.wu@...el.com>
CC:	<kbuild-all@...org>, open list <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [next:master 9165/9394] arch/tile/mm/fault.c:845:1: warning:
 label 'done' defined but not used

On 06/04/2015 12:24 PM, kbuild test robot wrote:
> Hi Chris,
>
> First bad commit (maybe != root cause):
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   94feb25d6fcd34b0d45c18cf0185d83d0c13c60a
> commit: 41dd496c8d9f622efff2c3b92ee308e13f58f639 [9165/9394] tile: force CONFIG_TILEGX if ARCH != tilepro
> config: tile-allnoconfig (attached as .config)
> reproduce:
>    wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>    chmod +x ~/bin/make.cross
>    git checkout 41dd496c8d9f622efff2c3b92ee308e13f58f639
>    # save the attached .config to linux build tree
>    make.cross ARCH=tile
>
> All warnings (new ones prefixed by >>):
>
>     arch/tile/mm/fault.c: In function 'do_page_fault':
>>> arch/tile/mm/fault.c:845:1: warning: label 'done' defined but not used [-Wunused-label]
> --
>>> kernel/sched/rt.c:64:13: warning: 'push_irq_work_func' declared 'static' but never defined [-Wunused-function]

This last warning looks like it comes from commit b6366f048e0c,
"sched/rt: Use IPI to trigger RT task push migration instead of pulling".
The declaration of push_irq_work_func() should be guarded by
HAVE_RT_PUSH_IPI, not CONFIG_SMP.

I will fix the first warning by refactoring tile's do_page_fault() more like
the way it was done for x86, which avoids complicated ifdefs for
the "done" label to only instantiate it based on whether the various
code paths that jump to it are ifdef'ed in or not.

Thanks!

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/