[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 6 Jun 2015 14:56:11 +0200
From: Valentin Rothberg <valentinrothberg@...il.com>
To: Paul Bolle <pebolle@...cali.nl>
Cc: Jean-Baptiste Theou <jtheou@...neo-embedded.us>,
Wim Van Sebroeck <wim@...ana.be>,
Guenter Roeck <linux@...ck-us.net>,
linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] gpio_wdt: Add option for early registration
On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote:
> On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
>
> > +config GPIO_WATCHDOG_ARCH_INITCALL
> > + bool "Register the watchdog as early as possible"
> > + depends on GPIO_WATCHDOG=y
> > + help
> > + In some situations, the default initcall level (module_init)
> > + in not early enough in the boot process to avoid the watchdog
> > + to be triggered.
> > + If you say yes here, the initcall level would be raised to
> > + arch_initcall.
> > + If in doubt, say N.
>
> > --- a/drivers/watchdog/gpio_wdt.c
> > +++ b/drivers/watchdog/gpio_wdt.c
>
> > +#ifdef GPIO_WATCHDOG_ARCH_INITCALL
>
> You meant
> #ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL
>
> Please use scripts/checkkconfigsymbols.py.
checkkconfigsymbols.py only checks CONFIG_ prefix symbols. Since this
prefix is missing here, the script would not complain. But that's
an interesting case and worth checking for.
Kind regards,
Valentin
>
> > +static int __init gpio_wdt_init(void)
> > +{
> > + return platform_driver_register(&gpio_wdt_driver);
> > +}
> > +arch_initcall(gpio_wdt_init);
> > +#else
> > module_platform_driver(gpio_wdt_driver);
> > +#endif
>
> The entire patch is basically an elaborate NOP. How did this pass your
> testing?
>
>
> Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists