[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 07 Jun 2015 01:07:01 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Robert Jarzmik <robert.jarzmik@...e.fr>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>
CC: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface
Hello.
On 06/07/2015 12:09 AM, Robert Jarzmik wrote:
> The pxa27x SoCs have an embedded camera host controller. Add the
> description to the family description.
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> ---
> arch/arm/boot/dts/pxa27x.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> index 506db86..9ebfd7f 100644
> --- a/arch/arm/boot/dts/pxa27x.dtsi
> +++ b/arch/arm/boot/dts/pxa27x.dtsi
> @@ -77,6 +77,23 @@
> clocks = <&clks CLK_KEYPAD>;
> status = "disabled";
> };
> +
> + pxa_camera: pxa_camera@...00000 {
The ePAPR standard has something to say about the node naming:
"The name of a node should be somewhat generic, reflecting the function of the
device and not its precise programming model." So I'd suggest "video@...00000"
instead...
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists