linux-kernel - Re: [PATCH] EDAC, mce_amd_inj: Include irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 6 Jun 2015 09:50:50 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
Cc:	dougthompson@...ssion.com, mchehab@....samsung.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	fengguang.wu@...el.com, kbuild-all@...org
Subject: Re: [PATCH] EDAC, mce_amd_inj: Include irq_vectors header to fix
 build errors

On Fri, Jun 05, 2015 at 06:07:34PM -0500, Aravind Gopalakrishnan wrote:
> Even though !CONFIG_SMP and MCE injection are practically mutually
> exclusive, it's better to include irq_vectors.h just in case
> randconfig builders out there don't set CONFIG_SMP.
> 
> When that happens, DEFERRED_ERROR_VECTOR and THRESHOLD_APIC_VECTOR
> macro definitions go out of scope and kernel build will fail.

Good!

> Tested the .config that broke the build against latest tip with
> changes in for-next branch of bp.git and it builds fine now.
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Cc: kbuild-all@...org
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
> ---
>  drivers/edac/mce_amd_inj.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
> index 3f7217f..3e1b53f 100644
> --- a/drivers/edac/mce_amd_inj.c
> +++ b/drivers/edac/mce_amd_inj.c
> @@ -18,6 +18,7 @@
>  #include <linux/string.h>
>  #include <linux/uaccess.h>
>  #include <asm/mce.h>
> +#include <asm/irq_vectors.h>
>  
>  #include "mce_amd.h"

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/