linux-kernel - Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Jun 2015 10:11:55 +0200
From:	Carlo Caione <carlo@...one.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Carlo Caione <carlo@...one.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct

On Sun, Jun 7, 2015 at 3:33 PM, Axel Lin <axel.lin@...ics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/irqchip/irq-sunxi-nmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
> index 12f547a..eb9b59e 100644
> --- a/drivers/irqchip/irq-sunxi-nmi.c
> +++ b/drivers/irqchip/irq-sunxi-nmi.c
> @@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
>         irqd_set_trigger_type(data, flow_type);
>         irq_setup_alt_chip(data, flow_type);
>
> -       for (i = 0; i <= gc->num_ct; i++, ct++)
> +       for (i = 0; i < gc->num_ct; i++, ct++)
>                 if (ct->type & flow_type)
>                         ctrl_off = ct->regs.type;

Acked-by: Carlo Caione <carlo@...lessm.com>

-- 
Carlo Caione
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/