linux-kernel - Re: [PATCH 07/25] mm, vmscan: Make kswapd think of reclaim in terms of nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jun 2015 15:05:00 +0800
From:	"Hillf Danton" <hillf.zj@...baba-inc.com>
To:	"Mel Gorman" <mgorman@...e.de>
Cc:	<linux-mm@...ck.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"Rik van Riel" <riel@...hat.com>,
	"Johannes Weiner" <hannes@...xchg.org>,
	"Michal Hocko" <mhocko@...e.cz>
Subject: Re: [PATCH 07/25] mm, vmscan: Make kswapd think of reclaim in terms of nodes

> -	/* Reclaim above the high watermark. */
> -	sc->nr_to_reclaim = max(SWAP_CLUSTER_MAX, high_wmark_pages(zone));
> +	/* Aim to reclaim above all the zone high watermarks */
> +	for (z = 0; z <= end_zone; z++) {
> +		zone = pgdat->node_zones + end_zone;
s/end_zone/z/ ?
> +		nr_to_reclaim += high_wmark_pages(zone);
> 
[...]
> @@ -3280,13 +3177,26 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
>  			compact_pgdat(pgdat, order);
> 
>  		/*
> +		 * Stop reclaiming if any eligible zone is balanced and clear
> +		 * node writeback or congested.
> +		 */
> +		for (i = 0; i <= *classzone_idx; i++) {
> +			zone = pgdat->node_zones + i;
> +
> +			if (zone_balanced(zone, sc.order, 0, *classzone_idx)) {
> +				clear_bit(PGDAT_CONGESTED, &pgdat->flags);
> +				clear_bit(PGDAT_DIRTY, &pgdat->flags);
> +				break;
s/break/goto out/ ?
> +			}
> +		}
> +
> +		/*
>  		 * Raise priority if scanning rate is too low or there was no
>  		 * progress in reclaiming pages
>  		 */
>  		if (raise_priority || !sc.nr_reclaimed)
>  			sc.priority--;
> -	} while (sc.priority >= 1 &&
> -		 !pgdat_balanced(pgdat, order, *classzone_idx));
> +	} while (sc.priority >= 1);
> 
>  out:
>  	/*
> --
> 2.3.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/