linux-kernel - Re: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jun 2015 10:30:33 +0200
From:	Borislav Petkov <bp@...e.de>
To:	Huang Rui <ray.huang@....com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...capital.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	X86 ML <x86@...nel.org>, Fengguang Wu <fengguang.wu@...el.com>,
	Aaron Lu <aaron.lu@...el.com>,
	Suravee Suthikulanit <suravee.suthikulpanit@....com>,
	Tony Li <tony.li@....com>, Ken Xue <ken.xue@....com>
Subject: Re: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a
 configurable timer

On Fri, Jun 12, 2015 at 03:50:33PM +0800, Huang Rui wrote:
> Yeah, but I remembered at last time, someone tell me we shouldn't
> force to set timer always enabled. So I add this interface to expose
> more clearly. :)

Yeah, but this interface would make users go and look at it and try to
remember what the enable parameter stood for.

> So could I use __mwaitx directly like below:
> 
> __monitorx(&dummy, 0, 0);
> __mwaitx(0xf, delay, MWAITX_ECX_TIMER_ENABLE);

Yes, this is more straight-forward and what the hardware instructions
take, so more intuitive.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/