lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Jun 2015 09:34:35 +0200 From: Nicholas Mc Guire <der.herr@...r.at> To: Julia Lawall <julia.lawall@...6.fr> Cc: Nicholas Mc Guire <hofrat@...dl.org>, Gilles Muller <Gilles.Muller@...6.fr>, Nicolas Palix <nicolas.palix@...g.fr>, Michal Marek <mmarek@...e.cz>, Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>, John Stultz <john.stultz@...aro.org>, cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org Subject: Re: [PATCH RFC V2] coccinelle: flag constants being passed for jiffies On Sun, 14 Jun 2015, Julia Lawall wrote: > > +@...ipt:python depends on report@ > > +p << cc.p; > > +timeout << cc.C; > > +@@ > > + > > +if str.isdigit(timeout): > > + if (int(timeout) != 1): > > + msg = "WARNING: timeout (%s) seems HZ dependent" % (timeout) > > + coccilib.report.print_report(p[0], msg) > > The parentheses in the warning messages around the timeouts seem a little > strange to me. > should be \"%s\" I guess - will fix that and the other findings - just waiting for feedback if it makes any sense at all to include something like this. > Otherwise, as a semantic patch, it looks fine. I can't judge the problem > being solved though. > it found aproximately 30 cases in the kernel some of which have been fixed already and none seem to be false postitives - the hardcoded "2" really being the only open issue if those should be counted as false-postitives and filtered. I'm not aware of any case in the kernel where the passing of a jiffies value is intentionally HZ dependent - so I guess atleast warning on this makes sense. Anyway it might also make more sense to put something like this into one of the build-bots rather than push it into mainline for general use. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists