lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Jun 2015 17:51:35 -0700 From: Tim Kryger <tim.kryger@...il.com> To: Thierry Reding <thierry.reding@...il.com> Cc: Jonathan Richardson <jonathar@...adcom.com>, Dmitry Torokhov <dtor@...gle.com>, Anatol Pomazau <anatol@...gle.com>, Arun Ramamurthy <arun.ramamurthy@...adcom.com>, Scott Branden <sbranden@...adcom.com>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux PWM <linux-pwm@...r.kernel.org> Subject: Re: [PATCH v8 1/5] drivers: pwm: core: Add pwmchip_add_inversed On Fri, Jun 12, 2015 at 2:45 AM, Thierry Reding <thierry.reding@...il.com> wrote: > On Tue, May 26, 2015 at 01:08:16PM -0700, Jonathan Richardson wrote: >> From: Tim Kryger <tim.kryger@...il.com> >> >> Add a new function to register a PWM chip with channels that have their >> initial polarity as inversed. This benefits drivers of controllers that >> by default operate with inversed polarity by removing the need to modify >> the polarity during initialization. >> >> Signed-off-by: Tim Kryger <tim.kryger@...il.com> >> Signed-off-by: Jonathan Richardson <jonathar@...adcom.com> >> --- >> drivers/pwm/core.c | 36 ++++++++++++++++++++++++++++-------- >> include/linux/pwm.h | 6 ++++++ >> 2 files changed, 34 insertions(+), 8 deletions(-) > > I had to bikeshed this a little, so I ended up applying a variant that > exports pwmchip_add_with_polarity() instead of having the additional > wrapper. The rationale here is that pwmchip_add_with_polarity() is more > explicit than pwmchip_add_inversed(). > > Thierry Sounds good. Thanks. -Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists