linux-kernel - Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2015 13:39:55 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	"Abdul, Hussain (H.)" <habdul@...teon.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"Dighe, Niranjan (N.)" <ndighe@...teon.com>,
	"chris.park@...el.com" <chris.park@...el.com>,
	"Ravindran, Madhusudhanan (M.)" <mravindr@...teon.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"johnny.kim@...el.com" <johnny.kim@...el.com>,
	"rachel.kim@...el.com" <rachel.kim@...el.com>,
	"dean.lee@...el.com" <dean.lee@...el.com>
Subject: Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons

On Tue, Jun 16, 2015 at 07:33:42AM +0000, Abdul, Hussain (H.) wrote:
> From: Abdul Hussain <habdul@...teon.com>
> 
> This patch removes unwanted true and false from boolean tests.
> 
> Signed-off-by: Abdul Hussain <habdul@...teon.com>
> ---
<snip>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 17ab5cd..be1f6bf 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -7816,7 +7816,7 @@ static void *host_int_ParseJoinBssParam(tstrNetworkInfo *ptstrNetworkInfo)
>  					pNewJoinBssParam->rsn_cap[1] = pu8IEs[rsnIndex + 1];
>  					rsnIndex += 2;
>  				}
> -				pNewJoinBssParam->rsn_found = 1;
> +				pNewJoinBssParam->rsn_found = true;
But this is not a boolean test, this is an assignement.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/