linux-kernel - Re: [PATCH v3 4/5] serial/8250_fintek: Support keys different than default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2015 10:50:30 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Peter Huewe <PeterHuewe@....de>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, peter_hong@...tek.com.tw
Subject: Re: [PATCH v3 4/5] serial/8250_fintek: Support keys different than
 default

On 06/16/2015, 10:41 AM, Ricardo Ribalda Delgado wrote:
> @@ -148,20 +148,25 @@ static int fintek_8250_rs485_config(struct uart_port *port,
>  	return 0;
>  }
>  
> -static int fintek_8250_base_port(void)
> +static int fintek_8250_base_port(u8 *key)
>  {
>  	static const u16 addr[] = {0x4e, 0x2e};
> -	int i;
> +	static const u16 keys[] = {0x77, 0xa0, 0x87, 0x67};

Hi, given keys are treated as u8 everywhere, this should be u8 too.

regards,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/