linux-kernel - Re: serial: stm32-usart: use of undefined SERIAL_STM32_USART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2015 10:47:32 +0200
From:	Maxime Coquelin <mcoquelin.stm32@...il.com>
To:	Andreas Ruprecht <andreas.ruprecht@....de>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Stefan Hengelein <stefan.hengelein@....de>,
	Valentin Rothberg <valentinrothberg@...il.com>,
	Paul Bolle <pebolle@...cali.nl>
Subject: Re: serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE

Hi Andreas,

2015-06-15 14:45 GMT+02:00 Andreas Ruprecht <andreas.ruprecht@....de>:
> Hi Maxime,
>
> your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
> was merged into linux-next today (i.e., next-20150615), and contains the
> following piece of code:
>
> [...]
> #if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) &&
> defined(CONFIG_MAGIC_SYSRQ)
> #define SUPPORT_SYSRQ
> #endif
> [...]
>
> The #if block can never be enabled as no symbol named
> SERIAL_STM32_USART_CONSOLE is defined in Kconfig. Did you maybe mean
> SERIAL_STM32_CONSOLE which you introduce in the same commit?

Yes, you a right, I meant SERIAL_STM32_CONSOLE.
I will prepare a fix.

>
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de). There is also a
> tool in the Linux tree itself that can detect such issues
> (scripts/checkkconfigsymbols.py).

Ok thanks for the pointer! I didn't know these tools.

Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/