linux-kernel - Re: [PATCH] sched/deadline: remove needless parameter in dl_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2015 11:27:56 +0200
From:	Luca Abeni <luca.abeni@...tn.it>
To:	Zhiqiang Zhang <zhangzhiqiang.zhang@...wei.com>,
	linux-kernel@...r.kernel.org, peterz@...radead.org,
	juri.lelli@...il.com
Subject: Re: [PATCH] sched/deadline: remove needless parameter in dl_runtime_exceeded()

Hello,

On 06/15/2015 05:15 AM, Zhiqiang Zhang wrote:
> Sine commit 269ad80(sched/deadline: Avoid double-accounting in
> case of missed deadlines), parameter rq is no longer used, so
> remove it.
I do not know if other people have plans to use this "rq" parameter,
but the patch looks ok to me.


			Thanks,
				Luca


>
> Signed-off-by: Zhiqiang Zhang <zhangzhiqiang.zhang@...wei.com>
> ---
>   kernel/sched/deadline.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 5e95145..437ecdc 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -640,7 +640,7 @@ void init_dl_task_timer(struct sched_dl_entity *dl_se)
>   }
>
>   static
> -int dl_runtime_exceeded(struct rq *rq, struct sched_dl_entity *dl_se)
> +int dl_runtime_exceeded(struct sched_dl_entity *dl_se)
>   {
>   	return (dl_se->runtime <= 0);
>   }
> @@ -684,7 +684,7 @@ static void update_curr_dl(struct rq *rq)
>   	sched_rt_avg_update(rq, delta_exec);
>
>   	dl_se->runtime -= dl_se->dl_yielded ? 0 : delta_exec;
> -	if (dl_runtime_exceeded(rq, dl_se)) {
> +	if (dl_runtime_exceeded(dl_se)) {
>   		dl_se->dl_throttled = 1;
>   		__dequeue_task_dl(rq, curr, 0);
>   		if (unlikely(!start_dl_timer(dl_se, curr->dl.dl_boosted)))
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/