linux-kernel - Re: [PATCH] Staging: comedi: Simplify a trivial if-return sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2015 14:11:54 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	"Abdul, Hussain (H.)" <habdul@...teon.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ravindran, Madhusudhanan (M.)" <mravindr@...teon.com>,
	"Dighe, Niranjan (N.)" <ndighe@...teon.com>
Subject: Re: [PATCH] Staging: comedi: Simplify a trivial if-return sequence

On 16/06/15 08:58, Abdul, Hussain (H.) wrote:
> From: Abdul Hussain <habdul@...teon.com>
>
> This patch simplify a trivial if-return sequence. Possibly combine with
> a preceding function call.
>
> Signed-off-by: Abdul Hussain <habdul@...teon.com>
> ---
>   drivers/staging/comedi/drivers/dac02.c        | 6 +-----
>   drivers/staging/comedi/drivers/daqboard2000.c | 6 +-----
>   drivers/staging/comedi/drivers/dmm32at.c      | 6 +-----
>   drivers/staging/comedi/drivers/fl512.c        | 6 +-----
>   drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
>   drivers/staging/comedi/drivers/s626.c         | 6 +-----
>   6 files changed, 6 insertions(+), 30 deletions(-)
>

Ideally, this should be split into separate patches.

[snip]
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index 611b0a3..0fe40c2 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
>   		return result;
>
>   	s = &dev->subdevices[2];
> -	result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
> +	return subdev_8255_init(dev, s, daqboard2000_8255_cb,
>   				  dioP2ExpansionIO8Bit);

That 'dioP2ExpansionIO8Bit' line could do with being un-indented by a 
couple of spaces so it still lines up with the 'dev' on the preceding line.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/