linux-kernel - Re: [PATCH] Hotplug: fix the bug that the system is down,when memory is not in node0 and cpu is logically hotadded.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Jun 2015 10:19:47 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	gongzg <gongzhaogang@...pur.com>
Cc:	tj@...nel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	SongXiumiao <songxiumiao@...pur.com>
Subject: Re: [PATCH] Hotplug: fix the bug that the system is down,when memory
 is not in node0 and cpu is logically hotadded.

On Wed, Jun 17, 2015 at 5:46 PM, gongzg <gongzhaogang@...pur.com> wrote:
> From: GongZhaogang <gongzhaogang@...pur.com>
>
> By analysing the bug function call trace,we find that create_worker function
> will alloc the memory from node0.Because node0 is offline,the allocation is
> failed.Then we add a condition to ensure the node is online and
> system can alloc memory from a node that is online.
>
> Follow is the bug information:

>
> Signed-off-by: SongXiumiao <songxiumiao@...pur.com>

I still think you should add at least one space after your periods and
commas, and that you should be able to shorten your subject line.
Explain the exact bug in your commit message.

I also just noticed that the From/Signed-off-by names and emails don't
match. If SongXiumiao wrote the patch, From: should contain that name
and email. And since you are sending it, you will have to add your
sign-off as well.

So here's a suggestion of how your commit message could look:

Subject: [PATCH] hotplug: fix oops when adding cpu
From: SongXiumiao <songxiumiao@...pur.com>

If memory is not in node0 and a cpu is logically hotadded, the kernel oopses ...

By analyzing ...

Here's the backtrace:
...

Signed-off-by: SongXiumiao <songxiumiao@...pur.com>
Signed-off-by: GongZhaogang <gongzhaogang@...pur.com>

Thanks,
Frans


> ---
>  kernel/workqueue.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 586ad91..22d194c 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3253,7 +3253,8 @@ static struct worker_pool *get_unbound_pool(const struct workqueue_attrs *attrs)
>         if (wq_numa_enabled) {
>                 for_each_node(node) {
>                         if (cpumask_subset(pool->attrs->cpumask,
> -                                          wq_numa_possible_cpumask[node])) {
> +                                   wq_numa_possible_cpumask[node])
> +                                              && node_online(node)) {
>                                 pool->node = node;
>                                 break;
>                         }
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/