linux-kernel - Re: [PATCH] arm64: dts: symlink cros-ec-keyboard from arm to arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Jun 2015 12:13:41 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Will Deacon <will.deacon@....com>
Cc:	"linux-mediatek@...ts.infradead.org" 
	<linux-mediatek@...ts.infradead.org>,
	Nicolas Boichat <drinkcat@...omium.org>,
	Olof Johansson <olofj@...omium.org>,
	Eddie Huang <eddie.huang@...iatek.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Mark Rutland <Mark.Rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Catalin Marinas <Catalin.Marinas@....com>,
	"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: symlink cros-ec-keyboard from arm to arm64

On Tue, Jun 16, 2015 at 10:55 PM, Will Deacon <will.deacon@....com> wrote:
> On Tue, Jun 16, 2015 at 03:35:41PM +0100, Daniel Kurtz wrote:
>> The cros-ec-keyboard.dtsi snippet is useful for both arm and arm64 boards.
>> Create a link between the two.
>>
>> This may not be the most scalable solution, so consider it temporary until
>> we find a more central repository for such shared .dtsi snippets.
>
> I don't have strong opinions either way, but we should be consistent as
> to whether we use relative paths:
>
>   http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/350267.html
>
> or symlinks, like below.
>
> Does anybody have some technical arguments one way or the other?

 /include/ "../../../../arm/boot/dts/cros-ec-keyboard.dtsi"

Directly embedding the relative path to .dtsi in /arm/ from .dts in
/arm64/ is more straightforward and does not require maintaining extra
symlink .dtsi files.

I actually like it better than the symlink that I proposed :-).
Consider my patch abandoned, unless someone else feels strongly.

-Dan

>
> Will
>
>> Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>
>> ---
>>  arch/arm64/boot/dts/cros-ec-keyboard.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>  create mode 120000 arch/arm64/boot/dts/cros-ec-keyboard.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
>> new file mode 120000
>> index 0000000..42220ac
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
>> @@ -0,0 +1 @@
>> +../../../arm/boot/dts/cros-ec-keyboard.dtsi
>> \ No newline at end of file
>> --
>> 2.2.0.rc0.207.ga3a616c
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/