linux-kernel - Re: [PATCH 1/1] pci: xgene: Fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 19:39:07 -0700
From:	Duc Dang <dhdang@....com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	linux-arm <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tanmay Inamdar <tinamdar@....com>, patches <patches@....com>
Subject: Re: [PATCH 1/1] pci: xgene: Fix compilation warning

On Thu, Jun 18, 2015 at 3:57 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Thu, Jun 18, 2015 at 5:10 PM, Duc Dang <dhdang@....com> wrote:
>> commit 979595bcb8da ("PCI: xgene: Allow config access to Root Port even
>> when link is down") removes the port->link_up check, which makes 'port'
>> become unused variable. This patch remove struct xgene_pcie_port *port
>> declaration to avoid compilation warning.
>>
>> Signed-off-by: Duc Dang <dhdang@....com>
>> Signed-off-by: Tanmay Inamdar <tinamdar@....com>
>
> I folded this fix into the original patch and updated my branch.  Thanks!

Thanks, Bjorn.
>
>> ---
>>  drivers/pci/host/pci-xgene.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
>> index 3684126..105fd83 100644
>> --- a/drivers/pci/host/pci-xgene.c
>> +++ b/drivers/pci/host/pci-xgene.c
>> @@ -137,8 +137,6 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
>>  static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
>>                               int offset)
>>  {
>> -       struct xgene_pcie_port *port = bus->sysdata;
>> -
>>         if ((pci_is_root_bus(bus) && devfn != 0) ||
>>             xgene_pcie_hide_rc_bars(bus, offset))
>>                 return NULL;
>> --
>> 1.9.1
>>



-- 
Regards,
Duc Dang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/