linux-kernel - Re: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Jun 2015 14:18:06 -0400
From:	Ilia Mirkin <imirkin@...m.mit.edu>
To:	Dave Hansen <dave@...1.net>
Cc:	dave.hansen@...ux.intel.com, john@...nmccutchan.com,
	rlove@...ve.org, eparis@...isplace.org, viro@...iv.linux.org.uk,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED

On Fri, Jun 19, 2015 at 2:07 PM, Dave Hansen <dave@...1.net> wrote:
>
> From: Dave Hansen <dave.hansen@...ux.intel.com>
>
> I have a little microbenchmark that sits and does write() in a loop.
> The number one kernel function in the profiles is __srcu_read_lock()
> from fsnotify().  I decided to turn off INOTIFY in order to see what
> the potential from optimizing this path would be.  I ended up with
> a system at the rescue console as systemd complained that dependencies
> were not met mounting some non-root filesystems:
>
>         systemd: inotify_init1() failed: Function not implemented
>         systemd: Dependency failed for Mark the need to relabel after reboot.
>         systemd: Triggering OnFailure= dependencies of local-fs.target.
>         systemd: inotify_init1() failed: Function not implemented
>         systemd: Dependency failed for /gcc.
>
> It looks like CONFIG_INOTIFY is now a critical part of any system
> that wants to both use systemd and boot.  Let's make it depend
> on CONFIG_EMBEDDED.

Is systemd depending on something really reason enough to make it
depend on EMBEDDED? For example all the cgroups stuff is not only not
dependent on embedded, but also off by default, and I'm sure there are
a boatload of other dependencies which any normal system has no
business worrying about but that are required by systemd.

  -ilia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/