linux-kernel - Re: [PATCH 9/9] Staging: sm750fb: ddk750_swi2c.c: Shorten lines to 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 22:09:52 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Isaac Assegai <isaac.a.travers@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-fbdev@...r.kernel.org, teddy.wang@...iconmotion.com,
	sudipm.mukherjee@...il.com
Subject: Re: [PATCH 9/9] Staging: sm750fb: ddk750_swi2c.c: Shorten lines to
 80 characters

On Thu, Jun 18, 2015 at 09:48:56PM -0700, Isaac Assegai wrote:
> Shorten lines to be under 80 characters in ddk750_swi2c.c
> to rectify the following checkpatch warnings:
> WARNING: line over 80 characters
> 
> Signed-off-by: Isaac Assegai <isaac.a.travers@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_swi2c.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
> index 5133bcc..1e684e2 100644
> --- a/drivers/staging/sm750fb/ddk750_swi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_swi2c.c
> @@ -126,7 +126,10 @@ void swI2CSCL(unsigned char value)
>  
>  	ulGPIODirection = PEEK32(g_i2cClkGPIODataDirReg);
>  	if (value) {    /* High */
> -		/* Set direction as input. This will automatically pull the signal up. */
> +		/**

Multi-line comments don't have two ** characters, that's just for
kerneldoc format, so I can't take this patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/