linux-kernel - Re: [PATCH] staging: make board support depend on CLKDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Jun 2015 22:45:00 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Magnus Damm <damm+renesas@...nsource.se>,
	Simon Horman <horms+renesas@...ge.net.au>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: make board support depend on CLKDEV_LOOKUP

Hi Paul,

On Sat, Jun 20, 2015 at 9:27 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:
> Building allmodconfig for arch/cris currently fails with:
>
> drivers/built-in.o: In function `board_staging_register_clock':
> drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
> make: *** [vmlinux] Error 1
>
> The clk_add_alias lives in drivers/clk/clkdev.c and that file
> is only compiled for CONFIG_CLKDEV_LOOKUP, so it would seem
> we need to add a dependency on that.

Thanks!

There seems to be another missing dependency on OF_IRQ:

drivers/built-in.o: In function `board_staging_gic_fixup_resources':
(.init.text+0x21c2): undefined reference to `irq_create_of_mapping'

> Cc: Magnus Damm <damm+renesas@...nsource.se>
> Cc: Simon Horman <horms+renesas@...ge.net.au>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>

> ---
>  drivers/staging/board/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/board/Kconfig b/drivers/staging/board/Kconfig
> index b8ee81840666..4ff5a795055f 100644
> --- a/drivers/staging/board/Kconfig
> +++ b/drivers/staging/board/Kconfig
> @@ -1,6 +1,6 @@
>  config STAGING_BOARD
>         bool "Staging Board Support"
> -       depends on OF_ADDRESS
> +       depends on OF_ADDRESS && CLKDEV_LOOKUP
>         help
>           Select to enable per-board staging support code.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/