linux-kernel - Re: [PATCH v5 5/7] extcon: arizona: Ensure variables are set for headphone detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Jun 2015 23:19:20 +0900
From:	Chanwoo Choi <cwchoi00@...il.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	Lee Jones <lee.jones@...aro.org>,
	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	devicetree <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v5 5/7] extcon: arizona: Ensure variables are set for
 headphone detection

Hi Charles,

Applied it.

Thanks,
Chanwoo Choi


On Sat, Jun 20, 2015 at 1:23 AM, Charles Keepax
<ckeepax@...nsource.wolfsonmicro.com> wrote:
> The detecting flag really refers to the microphone detection stage and
> as such should be cleared before arizona_identify_headphones is called.
> Also the mic flag should be set before identify headphones is called as
> well.
>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 8f0ef72..4c47eb2 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -765,10 +765,11 @@ static void arizona_micd_timeout_work(struct work_struct *work)
>         mutex_lock(&info->lock);
>
>         dev_dbg(info->arizona->dev, "MICD timed out, reporting HP\n");
> -       arizona_identify_headphone(info);
>
>         info->detecting = false;
>
> +       arizona_identify_headphone(info);
> +
>         arizona_stop_mic(info);
>
>         mutex_unlock(&info->lock);
> @@ -834,6 +835,9 @@ static void arizona_micd_detect(struct work_struct *work)
>
>         /* If we got a high impedence we should have a headset, report it. */
>         if (info->detecting && (val & ARIZONA_MICD_LVL_8)) {
> +               info->mic = true;
> +               info->detecting = false;
> +
>                 arizona_identify_headphone(info);
>
>                 ret = extcon_set_cable_state_(info->edev,
> @@ -849,8 +853,6 @@ static void arizona_micd_detect(struct work_struct *work)
>                                 ret);
>                 }
>
> -               info->mic = true;
> -               info->detecting = false;
>                 goto handled;
>         }
>
> @@ -863,10 +865,11 @@ static void arizona_micd_detect(struct work_struct *work)
>         if (info->detecting && (val & MICD_LVL_1_TO_7)) {
>                 if (info->jack_flips >= info->micd_num_modes * 10) {
>                         dev_dbg(arizona->dev, "Detected HP/line\n");
> -                       arizona_identify_headphone(info);
>
>                         info->detecting = false;
>
> +                       arizona_identify_headphone(info);
> +
>                         arizona_stop_mic(info);
>                 } else {
>                         info->micd_mode++;
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/