linux-kernel - Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 22 Jun 2015 09:49:58 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	Johannes Thumshirn <jthumshirn@...e.de>
Subject: Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer
 dereference

On Tue, Jun 02, 2015 at 06:44:48AM -0700, Guenter Roeck wrote:
> On 06/02/2015 03:25 AM, Johannes Thumshirn wrote:
> >In a21_wdt_remove() we do a watchdog_unregister_device() on struct
> >a21_wdt_drv->wdt but never assign it.
> >
> >Also move the dev_set_drvdata() call in front of the watchdog_register_device()
> >call, so it doesn't look like an error.
> >
> >Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> 
> Good catch.
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 
> Guenter
> 

Hi Wim,

Any objections to this one? Do you intent to take it for 4.2?

Thanks,
	Johannes

-- 
Johannes Thumshirn                                       Storage
jthumshirn@...e.de                             +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/