linux-kernel - Re: [PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Jun 2015 15:16:17 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	cw00.choi@...sung.com, myungjoo.ham@...sung.com,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v3 7/7] mfd: arizona: Update several pdata members to
 unsigned

On Fri, 19 Jun 2015, Charles Keepax wrote:

> Device tree and ACPI primarily deal with unsigned ints, many of the
> pdata members in the Arizona driver are signed ints but are only ever
> assigned positive values. Changing these pdata fields to unsigned ints
> avoids us having to choose between overly verbose code and Sparse
> warnings.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  include/linux/mfd/arizona/pdata.h |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)

Applied for v4.3, thanks.

> diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h
> index af44081..f2c8381 100644
> --- a/include/linux/mfd/arizona/pdata.h
> +++ b/include/linux/mfd/arizona/pdata.h
> @@ -104,7 +104,7 @@ struct arizona_pdata {
>  	 * useful for systems where and I2S bus with multiple data
>  	 * lines is mastered.
>  	 */
> -	int max_channels_clocked[ARIZONA_MAX_AIF];
> +	unsigned int max_channels_clocked[ARIZONA_MAX_AIF];
>  
>  	/** GPIO5 is used for jack detection */
>  	bool jd_gpio5;
> @@ -128,22 +128,22 @@ struct arizona_pdata {
>  	unsigned int hpdet_channel;
>  
>  	/** Extra debounce timeout used during initial mic detection (ms) */
> -	int micd_detect_debounce;
> +	unsigned int micd_detect_debounce;
>  
>  	/** GPIO for mic detection polarity */
>  	int micd_pol_gpio;
>  
>  	/** Mic detect ramp rate */
> -	int micd_bias_start_time;
> +	unsigned int micd_bias_start_time;
>  
>  	/** Mic detect sample rate */
> -	int micd_rate;
> +	unsigned int micd_rate;
>  
>  	/** Mic detect debounce level */
> -	int micd_dbtime;
> +	unsigned int micd_dbtime;
>  
>  	/** Mic detect timeout (ms) */
> -	int micd_timeout;
> +	unsigned int micd_timeout;
>  
>  	/** Force MICBIAS on for mic detect */
>  	bool micd_force_micbias;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/