lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Jun 2015 20:11:02 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Vitaly Kuznetsov <vkuznets@...hat.com> Cc: Olaf Hering <olaf@...fle.de>, "K. Y. Srinivasan" <kys@...rosoft.com>, linux-kernel@...r.kernel.org, devel@...uxdriverproject.org, apw@...onical.com, jasowang@...hat.com Subject: Re: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler On Tue, Jun 23, 2015 at 06:28:36PM +0200, Vitaly Kuznetsov wrote: > Olaf Hering <olaf@...fle.de> writes: > > > On Thu, Jun 04, K. Y. Srinivasan wrote: > > > >> +++ b/arch/x86/kernel/cpu/mshyperv.c > >> @@ -18,6 +18,9 @@ > >> #include <linux/efi.h> > >> #include <linux/interrupt.h> > >> #include <linux/irq.h> > >> +#ifdef CONFIG_KEXEC > >> +#include <linux/kexec.h> > >> +#endif > > > > Is this #ifdef required? > > > > No, it's not, but other parts of the same patch do (e.g. there is no > kexec_in_progress without CONFIG_KEXEC). We can probably omit #ifdef > here but I'm not sure it makes sense. No #ifdef should be in a .c file if at all possible, so please remove them all if you can. If not, then work to fix up the .h file properly so that you can. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists