linux-kernel - Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jun 2015 11:25:47 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Peter Hung <hpeter@...il.com>
Cc:	Johan Hovold <johan@...nel.org>, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	peter_hong@...tek.com.tw, tom_tsai@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote:
> Hi Johan,
> 
> Johan Hovold 於 2015/6/25 下午 04:06 寫道:
> >   - As Greg already mentioned, you need to implement gpio support using
> >     gpiolib, not a custom sysfs interface
> >
> > I don't have time to look closer at the architectural bits until next
> > week I'm afraid, but perhaps you could start with the above.
> 
> Thanks for your advices, I'll try to improve it again.
> But I had something need to clarify.
> 
> 1. The sysfs interface of the driver provide "limited output pin"
>     control. only support output 0/1, not support input mode.
>     Should I implement it as gpiolib?

Yes.

> 2. If it still recommends to implement with gpiolib, Could I implement
>     it and preserve the sysfs interface for legacy?

No, I'm afraid not. We don't want to have to maintain out-of-tree legacy
interfaces.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/