linux-kernel - [RFC] kthread_create_on_node is failing to honor the node choice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jun 2015 16:44:13 -0500
From:	Nathan Zimmer <nzimmer@....com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	Nathan Zimmer <nzimmer@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nishanth Aravamudan <nacc@...ux.vnet.ibm.com>,
	Tejun Heo <tj@...nel.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>, linux-kernel@...r.kernel.org
Subject: [RFC] kthread_create_on_node is failing to honor the node choice

In kthread_create_on_node we set_cpus_allowed to cpu_all_mask
regardless of what the node is requested.
This seems incorrect.

Signed-off-by: Nathan Zimmer <nzimmer@....com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Nishanth Aravamudan <nacc@...ux.vnet.ibm.com>
Cc: Tejun Heo <tj@...nel.org>
Cc: Lai Jiangshan <laijs@...fujitsu.com>
Cc: Mel Gorman <mgorman@...e.de>
Cc: linux-kernel@...r.kernel.org

---
 kernel/kthread.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/kthread.c b/kernel/kthread.c
index 10e489c..d885d66 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -318,7 +318,10 @@ struct task_struct *kthread_create_on_node(int (*threadfn)(void *data),
 		 * The kernel thread should not inherit these properties.
 		 */
 		sched_setscheduler_nocheck(task, SCHED_NORMAL, &param);
-		set_cpus_allowed_ptr(task, cpu_all_mask);
+		if (node == -1)
+			set_cpus_allowed_ptr(task, cpu_all_mask);
+		else
+			set_cpus_allowed_ptr(task, cpumask_of_node(node));
 	}
 	kfree(create);
 	return task;
-- 
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/