linux-kernel - Re: [PATCH v2 1/1] mm: move ->mremap() from file_operations to vm_operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Jun 2015 01:41:12 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	Andy Lutomirski <luto@...capital.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Benjamin LaHaise <bcrl@...ck.org>,
	Hugh Dickins <hughd@...gle.com>,
	Jeff Moyer <jmoyer@...hat.com>,
	Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...nel.org>,
	Pavel Emelyanov <xemul@...allels.com>
Subject: Re: [PATCH v2 1/1] mm: move ->mremap() from file_operations to
	vm_operations_struct

On 06/26, Kirill A. Shutemov wrote:
>
> > --- a/mm/mremap.c
> > +++ b/mm/mremap.c
> > @@ -276,8 +276,8 @@ static unsigned long move_vma(struct vm_area_struct *vma,
> >  				     need_rmap_locks);
> >  	if (moved_len < old_len) {
> >  		err = -ENOMEM;
> > -	} else if (vma->vm_file && vma->vm_file->f_op->mremap) {
> > -		err = vma->vm_file->f_op->mremap(vma->vm_file, new_vma);
> > +	} else if (vma->vm_ops && vma->vm_ops->mremap) {
> > +		err = vma->vm_ops->mremap(new_vma);
> >  	}
> >
> >  	if (unlikely(err)) {
>
> I'm not sure what is target tree for the patch.

I hope akpm can take this patch into -mm,

> Last hunk is not going to
> apply on Linus' tree or -next. Hm?

Yes, this depends on another fix I sent to Andrew (and you ;), as 0/1
explains the change in move_vma() textually depends on another patch I sent,

	[PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails
	http://marc.info/?l=linux-kernel&m=143475603713622

> Otherwise, looks good.
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

Thanks!

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/