linux-kernel - Re: drm/mgag200: doesn't work in panic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2015 11:58:17 +0200
From:	Daniel Vetter <daniel.vetter@...ll.ch>
To:	Borislav Petkov <bp@...en8.de>
Cc:	"Luck, Tony" <tony.luck@...el.com>,
	"Wang, Rui Y" <rui.y.wang@...el.com>,
	Dave Airlie <airlied@...hat.com>,
	"Clark, Rob" <robdclark@...il.com>,
	"Roper, Matthew D" <matthew.d.roper@...el.com>,
	"Chen, Gong" <gong.chen@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: drm/mgag200: doesn't work in panic context

On Mon, Jun 29, 2015 at 11:42 AM, Borislav Petkov <bp@...en8.de> wrote:
>> drm_fb_helper_panic isn't the only panic handler - fbdev/fbcon have
>> their own. They interfere, and fbdev blissfully assumes that it can
>> call almost any driver hook from hardirq context. Which means you'd
>> also need to consolidate the various hand-rolled (in drivers instead
>> of the fbdev helper) bits to offload fbdev callbacks to workers and
>> make sure we don't go boom in panics in there either.
>
> Hmmm, this would mean to go and tell them through the panic notifier
> to not do anything "risky" anymore. Perhaps even stop them from doing
> regular tasks which could become risky in the case of panic. I guess
> this would mean, we should be doing the same in other subsystems too.

Not sure that applies to other subsystems, it's really just history.
fbdev was designed for a world where register banging and some writes
to a gart was all you had to do for graphics, and you can very well do
that from hardirq context. And fbdev will take care of some simple
locking itself if needed. The problem really is that drm drivers are
anything but simple, and there's a bit of room to share more code and
tricks (and fix up even more corner-cases) between drm drivers in the
shared fbdev emulation library.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/