linux-kernel - Re: [PATCH -next] leds: fix aat1290 build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2015 10:08:50 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH -next] leds: fix aat1290 build errors

On Mon, Jun 29, 2015 at 7:44 AM, Jacek Anaszewski
<j.anaszewski@...sung.com> wrote:
> Hi Randy,
>
> Thanks for the patch.
>
>
> On 06/26/2015 09:00 PM, Randy Dunlap wrote:
>>
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
>> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
>>
>> drivers/built-in.o: In function `aat1290_led_remove':
>> leds-aat1290.c:(.text+0xe5d77): undefined reference to
>> `v4l2_flash_release'
>> drivers/built-in.o: In function `aat1290_led_probe':
>> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Jacek Anaszewski <j.anaszewski@...sung.com>
>> Cc: Bryan Wu <cooloney@...il.com>
>> Cc: Richard Purdie <rpurdie@...ys.net>
>> ---
>>   drivers/leds/Kconfig |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> --- linux-next-20150626.orig/drivers/leds/Kconfig
>> +++ linux-next-20150626/drivers/leds/Kconfig
>> @@ -42,6 +42,7 @@ config LEDS_88PM860X
>>   config LEDS_AAT1290
>>         tristate "LED support for the AAT1290"
>>         depends on LEDS_CLASS_FLASH
>> +       depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>>         depends on GPIOLIB
>>         depends on OF
>>         depends on PINCTRL
>>
>
> Acked-by: Jacek Anaszewski <j.anaszewski@...sung.com>
>

Good fix. thanks.
I merged into my tree.
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/