linux-kernel - Re: [PATCH] rtl8712:Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2015 13:09:27 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Ravi Teja Darbha <ravi2j@...il.com>
Cc:	Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
	mahfouz.saif.elyazal@...il.com, vthakkar1994@...il.com,
	haggai.eran@...il.com, sudipm.mukherjee@...il.com,
	krinkin.m.u@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote:
> 
> 1. Fix line over 80 characters warning.

Great, but:

> 2. The checkpatch warning at line 499 seems to be false positive.
> WARNING: else is not generally useful after a break or return
> #499: FILE: rtl8712_recv.c:499:
> +            return false;
> +        else
> 
> while(condition1) {
>     if(condition2)
>         foo();
>     else if(condition3)
>         return false;
>     else
>         break;
> }
> 
> The else condition here cannot be eliminated

Why does that belong here in this changelog entry?  Why would you want
this text to show up in the kernel log?

Please fix up.

Also:

> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter)
>  
>      /*init recv_buf*/
>      _init_queue(&precvpriv->free_recv_buf_queue);
> -    precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,
> -                         GFP_ATOMIC);
> +    precvpriv->pallocated_recv_buf =
> +        kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC);
>      if (precvpriv->pallocated_recv_buf == NULL)
>          return _FAIL;
>      precvpriv->precv_buf = precvpriv->pallocated_recv_buf + 4 -
> -- 
> 1.9.1

Your patches are corrupted and can not be applied.  Please fix your
email client.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/