linux-kernel - Re: [PATCH] scripts: checkpatch: ignore stable commit annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Jun 2015 16:45:54 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Felipe Balbi <balbi@...com>
Cc:	Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts: checkpatch: ignore stable commit annotation

On Tue, Jun 30, 2015 at 05:42:31PM -0500, Felipe Balbi wrote:
> On Tue, Jun 30, 2015 at 03:30:35PM -0700, Joe Perches wrote:
> > On Tue, 2015-06-30 at 17:07 -0500, Felipe Balbi wrote:
> > > When running scripts/checkpatch.pl on stable commits,
> > > we always get the error for not using 12-character
> > > commit hash abbreviation with shortlog within ("").
> > 
> > Looking at linux-stable v3.14.44 (randomly chosen), there
> > are also commit entries like:
> > 
> >    This is commit 0f540c3a7cfb91c9d7a19eb0c95c24 upstream.
> >  commit:  cb64edb6b89491edfdbae52ba7db9a8b8391d339 upstream
> > 
> > is -stable now using some script to tag these or is it
> > freehanded and happens to be reasonably consistent?
> 
> afaict, Greg uses a script. Greg ?

I use a script, but my script didn't create both of those lines, only
one of them, the bottom one.  The top one comes from David Miller's
scripts which he uses when he sends me networking stable patches.

Never run checkpatch on stable commits, that makes no sense at all as I
am pulling them directly from Linus's tree and there is nothing I can do
to change anything in them, nor would I ever want to.

> > If these are really scripted, the case-insensitive /i
> > shouldn't be necessary.
> 
> yeah, it was really just to be safer. What if Greg decides to change his
> script in the future ?

You shouldn't care, as you shouldn't be running the script and thinking
it matters, on stable tree commits.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/