linux-kernel - [GIT PULL] Replace module_init with an alternate initcall in non modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 30 Jun 2015 21:10:19 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	<torvalds@...ux-foundation.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: [GIT PULL] Replace module_init with an alternate initcall in non
 modules

This series of commits converts non-modular code that is using the
module_init() call to hook itself into the system to instead use one
of our alternate priority initcalls.

Unlike the previous series that used device_initcall and hence was a
runtime no-op, these commits change to one of the alternate initcalls,
because (a) we have them and (b) it seems like the right thing to do.
For example, it would seem logical to use arch_initcall for arch
specific setup code and fs_initcall for filesystem setup code.

This does mean however, that changes in the init ordering will be taking
place, and so there is a small risk that some kind of implicit init
ordering issue may lie uncovered.  But I think it is still better to
give these ones sensible priorities than to just assign them all to
device_initcall in order to exactly preserve the old ordering.

Thad said, we have already made similar changes in core kernel code
in commit c96d6660dc65b0a90aea9834bfd8be1d5656da18 ("kernel: audit/fix
non-modular users of module_init in core code") without any regressions
reported, so this type of change isn't without precedent.  It has also
got the same local testing and linux-next coverage as all the other
pull requests that I'm sending for this merge window have got.

Once again, there is an unused module_exit function removal that shows
up as an outlier upon casual inspection of the diffstat.

Original posting:
  "Replace module_init with an alternate initcall in non modules"
  https://lkml.kernel.org/r/1433120052-18281-1-git-send-email-paul.gortmaker@windriver.com

Thanks,
Paul.
---
The following changes since commit 0f57d86787d8b1076ea8f9cbdddda2a46d534a27:

  Linux 4.1-rc8 (2015-06-14 15:51:10 -1000)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git tags/module_init-alternate_initcall-v4.1-rc8

for you to fetch changes up to 5b00c1eb94e5936e5bf5cdd9ad1ddfbed0c39159:

  x86: perf_event_intel_pt.c: use arch_initcall to hook in enabling (2015-06-16 14:12:35 -0400)

----------------------------------------------------------------
Replace module_init with appropriate alternate initcall in non modules.

----------------------------------------------------------------
Paul Gortmaker (11):
      mm: replace module_init usages with subsys_initcall in nommu.c
      fs/notify: don't use module_init for non-modular inotify_user code
      netfilter: don't use module_init/exit in core IPV4 code
      x86: don't use module_init for non-modular core bootflag code
      powerpc: use subsys_initcall for Freescale Local Bus
      powerpc: don't use module_init for non-modular core hugetlb code
      arm: use subsys_initcall in non-modular pl320 IPC code
      lib/list_sort: use late_initcall to hook in self tests
      mm/page_owner.c: use late_initcall to hook in enabling
      x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling
      x86: perf_event_intel_pt.c: use arch_initcall to hook in enabling

 arch/powerpc/mm/hugetlbpage.c              | 2 +-
 arch/powerpc/sysdev/fsl_lbc.c              | 2 +-
 arch/x86/kernel/bootflag.c                 | 2 +-
 arch/x86/kernel/cpu/perf_event_intel_bts.c | 3 +--
 arch/x86/kernel/cpu/perf_event_intel_pt.c  | 3 +--
 drivers/mailbox/pl320-ipc.c                | 2 +-
 fs/notify/inotify/inotify_user.c           | 4 ++--
 lib/list_sort.c                            | 2 +-
 mm/nommu.c                                 | 4 ++--
 mm/page_owner.c                            | 2 +-
 net/ipv4/netfilter.c                       | 9 +--------
 11 files changed, 13 insertions(+), 22 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/