linux-kernel - Re: [PATCH] Staging: android: fix coding style and TODO file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2015 18:08:22 +0530
From:	Sohny Thomas <sohnythomas@...o.com>
To:	Frans Klaver <fransklaver@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, arve@...roid.com,
	riandrews@...roid.com, sumit.semwal@...aro.org, carlos@...rcia.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: android: fix coding style and TODO file



On Wednesday 01 July 2015 05:59 PM, Frans Klaver wrote:
> On Wed, Jul 1, 2015 at 2:22 PM, Sohny Thomas <sohnythomas@...o.com> wrote:
>>
>>
>> On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote:
>>> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas <sohnythomas@...o.com> wrote:
>>>> - removed non-existant issue from TODO file
>>>
>>> s,existant,existent,
>> Thanks missed that
>>>
>>>> kuid_t or uid_t not present in staging/android
>>>> - fixed 80 char limit exceeding line
>>>> - a newline after decelartions as per checkpatch.pl
>>>> - fixed an unnecessary typedef as reported by checkpatch.pl
>>>
>>> Fix one issue per patch, please.
>> Since these were all simple Fixes of about 1/2 lines , I thought to make a single patch.
> 
> They are simple fixes, but a reviewer still has to figure out what
> comment belongs to which code change. Since there's no reason for
> these changes to be atomic, you might as well split them up to make
> reviewing easier.
> 
Yeap, V2 coming with changes and fixes Sudip's catch too.
Thanks for your time.

-Sohny

> Frans
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/