linux-kernel - Re: [PATCH] Code cleanup - else is not generally useful after a break or return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2015 09:07:40 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Leung Timothy Chi King <contact@...othyleung.co>
Cc:	fabio.falzoi84@...il.com, joe@...ches.com,
	lambert.quentin@...il.com, tinajohnson.1234@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Code cleanup - else is not generally useful after a
 break or return

Your subject needs a hint as to what part of the kernel it is changing,
please fix that up to match what other patches have looked like for this
file.

On Wed, Jul 01, 2015 at 08:55:21AM -0700, Leung Timothy Chi King wrote:
> Ran checkpatch.pl on driver/staging/rts5208/sd.c and foudn a WARNING
> 'else is not generally useful after a break or return' on line 3523. I
> removed the else without affecting the logic and the WARNING is gone. I
> had compiled and modprobe rts5208 to double check as well.

That's good, but not needed here, please say why you did what you did,
but not in a narrative like you did.

> 
> Regards,
> Tim

This isn't needed either.

Can you fix up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/