linux-kernel - Re: [PATCH 41/41] clocksource: zevio: Migrate to new 'set-state' interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Jul 2015 22:11:59 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	linaro-kernel@...ts.linaro.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Daniel Tang <dt.tangr@...il.com>
Subject: Re: [PATCH 41/41] clocksource: zevio: Migrate to new 'set-state'
 interface

On 06/18/2015 12:54 PM, Viresh Kumar wrote:
> Migrate zevio driver to the new 'set-state' interface provided by
> clockevents core, the earlier 'set-mode' interface is marked obsolete
> now.
>
> This also enables us to implement callbacks for new states of clockevent
> devices, for example: ONESHOT_STOPPED.
>
> Cc: Daniel Tang <dt.tangr@...il.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---

[ ... ]

>   static irqreturn_t zevio_timer_interrupt(int irq, void *dev_id)
> @@ -162,7 +158,9 @@ static int __init zevio_timer_add(struct device_node *node)
>   	if (timer->interrupt_regs && irqnr) {
>   		timer->clkevt.name		= timer->clockevent_name;
>   		timer->clkevt.set_next_event	= zevio_timer_set_event;
> -		timer->clkevt.set_mode		= zevio_timer_set_mode;
> +		timer->clkevt.set_state_shutdown = zevio_timer_shutdown;
> +		timer->clkevt.set_state_oneshot = zevio_timer_set_oneshot;
> +		timer->clkevt.tick_resume	= zevio_timer_set_oneshot;

Why is tick_resume added here ?

>   		timer->clkevt.rating		= 200;
>   		timer->clkevt.cpumask		= cpu_all_mask;
>   		timer->clkevt.features		= CLOCK_EVT_FEAT_ONESHOT;
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/